Show
Ignore:
Timestamp:
06/29/08 10:26:00 (5 months ago)
Author:
peter
Message:

tsuite/auto/checkall.pl:

  • Treat sims that returned EXIT_FAILURE as "failed" rather than "crashed".
  • Treat sims with warnings as a separate class rather than "failed".
Files:
1 modified

Legend:

Unmodified
Added
Removed
  • trunk/tsuite/auto/checkall.pl

    r1997 r2140  
    2929$nOK = 0; 
    3030$nSkip = 0; 
     31$nFail = 0; 
    3132$nCrash = 0; 
    3233$nBotch = 0; 
     34$nWarn = 0; 
    3335 
    3436open( CRASHED, ">crashed.txt" ); 
     
    5355    { 
    5456        $checkEnd = 0; 
     57        $nWarnMessage = 0; 
    5558        $lgCrash = 0; 
     59        $lgFailure = 0; 
    5660        $lgBotch = 0; 
    5761        $lgAtmosNotFound = 0; 
     
    6468            { 
    6569                print SERIOUS "$output: $_"; 
     70                if( /W-/ ) 
     71                { 
     72                    ++$nWarnMessage; 
     73                } 
    6674            } 
    6775            if( /botch/ ) 
     
    94102                $lgCrash = 1; 
    95103            } 
    96 # this is the last line, so lgBotch is already determined. 
    97             if( /something went wrong\]/ && !$lgBotch ) 
    98             { 
    99                 $lgCrash = 1; 
     104# this is the last line, so lgBotch and nWarnMessage are already determined. 
     105            if( /something went wrong\]/ && !$lgBotch && $nWarnMessage == 0 ) 
     106            { 
     107                $lgFailure = 1; 
     108                ++$checkEnd; 
    100109            } 
    101110            if( /Error: stellar atmosphere file not found./ ) 
     
    115124            print SERIOUS "$output: crashed\n"; 
    116125            $lgSeriousProblems = 1; 
     126        } 
     127        elsif( $lgFailure ) 
     128        { 
     129            ++$nFail; 
     130            print SERIOUS "$output: returned with FAILURE status\n"; 
     131            $lgSeriousProblems = 1; 
     132        } 
     133        elsif( $nWarnMessage > 0 ) 
     134        { 
     135            ++$nWarn; 
    117136        } 
    118137        elsif( $lgBotch ) 
     
    140159close( SKIP ); 
    141160 
    142 if( $nMod != $nOK+$nSkip+$nCrash+$nBotch ) 
     161if( $nMod != $nOK+$nSkip+$nCrash+$nFail+$nWarn+$nBotch ) 
    143162{ 
    144163    print STDERR "\nINTERNAL ERROR: the number of sims don't add up!!!!!\n\n"; 
     
    149168if( -s "serious.txt" ) 
    150169{ 
    151     print "\nWARNING! crashes, botches or warnings were found. This is a serious problem.\n"; 
     170    print "\nWARNING! crashes, failures, botches or warnings were found. This is a serious problem.\n"; 
    152171    if( $nCrash > 0 ) 
    153172    { 
     
    215234    printf( ", %i crashed", $nCrash ); 
    216235} 
     236if( $nFail > 0 ) 
     237{ 
     238    printf( ", %i failed", $nFail ); 
     239} 
     240if( $nWarn > 0 ) 
     241{ 
     242    printf( ", %i have warnings", $nWarn ); 
     243} 
    217244if( $nBotch > 0 ) 
    218245{